This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
removed logback-xml from config to use NiFi default logback.xml #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looking forward for this change 👍 |
|
@alexnuttinck did you already have time to look into this PR? |
|
@hobe he is away this week |
alexnuttinck
approved these changes
Nov 9, 2020
|
lgtm, sorry for the delay. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please describe.
We'd like to customize the logging and therefore we want to mount a custom logback.xml file. This can be achieved by adding a custom configmap (via values.configmaps):
eg.:
`
configmaps:
keys:
mountPath: /opt/nifi/nifi-current/conf
`
Unfortunately there is already a default logback.xml mounted directly within the helm chart which also differs from the default logback.xml which is shipped with nifi (1.12.1)
Describe the solution you'd like
Removed the config/logback.xml file and the volume and volumeMounts from the statefulset for the logback.xml to get the default logback.xml which is shipped with NiFi image itself. Then it is possible to overwrite it with a custom file (via configmap in the values)
Describe alternatives you've considered
Other mount options or postStart scripts are not possible because the file is already mounted to conf/logback.xml and is readonly. It is also not possible to use another filepath to logback.xml via nifi.properties